fix(address-form): Update error message for address form #3909
Conversation
Bundle ReportChanges will increase total bundle size by 764 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 98.64% 98.63% -0.02%
==========================================
Files 828 828
Lines 15083 15092 +9
Branches 4319 4314 -5
==========================================
+ Hits 14879 14886 +7
- Misses 196 198 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 98.64% 98.63% -0.02%
==========================================
Files 828 828
Lines 15083 15092 +9
Branches 4319 4322 +3
==========================================
+ Hits 14879 14886 +7
- Misses 196 198 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 764 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 98.64% 98.63% -0.02%
==========================================
Files 828 828
Lines 15083 15092 +9
Branches 4311 4314 +3
==========================================
+ Hits 14879 14886 +7
- Misses 196 198 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 98.64% 98.63% -0.02%
==========================================
Files 828 828
Lines 15083 15092 +9
Branches 4311 4314 +3
==========================================
+ Hits 14879 14886 +7
- Misses 196 198 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
| if (error.message) { | ||
| return `Could not save billing address: ${error.message}` | ||
| } | ||
| return 'Could not save billing address. Please contact support for assistance.' |
There was a problem hiding this comment.
nit: we should add the email here too if this is the copy we wanna show. I.e. contact support at [email protected] or w/e it is (not sure myself haha)
There was a problem hiding this comment.
Updated!
looks like rest of app says [email protected] so used that
| mutate: updateAddress, | ||
| isLoading, | ||
| error, | ||
| reset, |
There was a problem hiding this comment.
do u know why we were able to get rid of this?
There was a problem hiding this comment.
oh is it because we want the error to persist?
There was a problem hiding this comment.
It seemed the former check of !reset would always be falsy because reset is a function. The form otherwise didn't require it. I think useMutation doesn't even return a property reset: () => void so that may be a leftover from some long-ago version of this that used react Form
Paired with this https://github.com/codecov/umbrella/pull/298/files
Properly show the user the error